feat(gql_socket_link): BREAKING CHANGE multiplex websocket connection #491
Conversation
|
Can you explain the change you did a bit more? From what I understand, there has always been just one WebSocket connection, no? And the code changes mostly add commented out code, I don't see any actual change in behaviour? |
|
I made a new commit. It's actually the result of a series of pull requests that I made. Auto resubscribe may or may not work when app is in foreground because of strange behaviors of web_socket_channel 3.0.3. Auto resubscribe definitely not work when app is in background (lock screen). So for this version, user has to manually resubscribe, I think it would be best to notify users that they need to manually resubscribe. And single-result-operation shouldn't be in for loop, it should complete on NextMessage instead of CompleteMessage, otherwise it might get re-sent. I made an issue in web_socket_channel dart-lang/http#1775 |
@knaeckeKami I'm making a breaking change in graphql_transport_ws.dart, please take a look
Streaming operations and single result operations are now multiplexed on a single connection. This means you have to manually resubscribe on subscriptions. On IOS and Android, when you app is in background (lock screen, etc.), all open sockets will be closed to save battery, and your app is freezed, no code from your app will run. Thus there is no way to reconnect a websocket connection when it is broken because no code from your app will run, you have to manually resubscribe on app resume (use
WidgetsBindingObserveror related packages). You can use old TransportWebSocketLink client to resubscribe, the underlying socket is newly acquired when you resubscribe.